Cleaning up - Githubissues

gomezzz / DistMSMatch

A MPI-distributed version of MSMatch integrating the PASEOS framework for physical modelling

GNU General Public License v3.0

0 stars 0 forks source link

Cleaning up #1

Closed gomezzz closed 2 years ago

gomezzz commented 2 years ago

Removing unused code
Adding docstrings
Removing multi-gpu support
Removing mixed precision stuff
Removing unused functionalities

gomezzz commented 2 years ago

@GabrieleMeoni So, I cleaned up a lot, maybe ideally clone this branch and have a look at the code and if you can run it etc.

Overall, I threw away a lot of code (it only supports eurosat-rgb atm) and restructured things a bit for comprehensibility.

What's missing atm:

[x] More docs
[x] environment.yml
[x] tests

With the notebook you can currently train a small UNet, ideally we should aim to train a model with this on Kalypso / Sandy to see that everything is working as intended once we are happy with the code?

gomezzz commented 2 years ago

Added most of the above things, I didn't add tests as it seems like overkill for now and is pretty difficult for this project. Looking forward to your feedback @GabrieleMeoni

GabrieleMeoni commented 2 years ago

I created another PR: https://github.com/gomezzz/DistMSMatch/pull/2 that should be merged to this branch before processing this PR. @gomezzz

GabrieleMeoni commented 2 years ago

@gomezzz I merged the other PR. I am ok with the code, everything works fine. Feel free to merge.