search

gomfunkel / node-exif

A node.js library to extract Exif metadata from images.
MIT License
581 stars 104 forks source link

Some code cleanup and future-proofing #3

Closed DougReeder closed 11 years ago

DougReeder commented 12 years ago

Thanks for writing such a useful module! Let me know if there's stuff I can add.

My development process uses Miller's JavaScript Lint to help me catch my own mistakes. It's helpful if all code can use the same configuration file. I'm not being anal about JavaScript syntax.

These changes will 1) avoid warning flags from lint-ing editors, which distract from understanding the source. 2) future-proof the code. I don't know that the "short" and "long" keywords will be enforced soon, but it is better not to use them.

DougReeder commented 12 years ago

I found a web page on Canon Exif makernote format (http://www.ozhiker.com/electronics/pjmt/jpeg_info/canon_mn.html); with a bit of help, I could probably add it to node-exif.

gomfunkel commented 11 years ago

Couldn't automatically merge this one properly so I merged some suggestions manually. Thanks for your contribution!