gomin1d / spigot-logger-for-bungee

This is a BungeeCord plugin that allows you to do logging in BungeeCord, as in Spigot.
https://www.spigotmc.org/resources/spigotloggerforbungee.55531/
2 stars 3 forks source link

Error with Bungeecord 1.16 #2

Closed TobiasHempel closed 2 years ago

TobiasHempel commented 3 years ago

Good evening,

I have the following problem: Since I updated my bungeecord server to 1.16 the following error occurs:

23:44:03 [WARNING] Error enabling plugin SpigotLoggerForBungee java.lang.UnsupportedOperationException: No class provided, and an appropriate one cannot be found. at org.apache.logging.log4j.LogManager.callerClass(LogManager.java:555) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:580) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:567) at ua.lokha.spigotloggerforbungee.SpigotLoggerForBungeePlugin.onLoad(SpigotLoggerForBungeePlugin.java:51) at net.md_5.bungee.api.plugin.PluginManager.enablePlugin(PluginManager.java:331) at net.md_5.bungee.api.plugin.PluginManager.loadPlugins(PluginManager.java:235) at net.md_5.bungee.BungeeCord.start(BungeeCord.java:271) at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:62) at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)

I know that you haven't tested the plugin on the 1.16 yet, but the plugin is the best of its kind and therefore I would like to continue using it! :)

Thank you very much and have a nice evening! Tobias

gomin1d commented 3 years ago

hi, sorry i didn't answer right away. for some reason there was no notification

i just checked on the latest bungeecord build, everything works fine for me
https://ci.md-5.net/job/BungeeCord/

how to reproduce your error? maybe you are using a third-party fork of BungeeCord?

Envel-Nikita-Gutsenkov commented 3 years ago

на botfilter то же самое

gomin1d commented 3 years ago

@Envel-Nikita-Gutsenkov не могу повторить. у меня на последнем билде BotFilter работает норм: image

Какая у тебя версия java?
я тестирую на java 8

Envel-Nikita-Gutsenkov commented 3 years ago

java 11-14, буду тестить заново

gomin1d commented 3 years ago

да, на java 14 ошибка есть

попробую исправить

gomin1d commented 3 years ago

исправил
https://github.com/lokha/spigot-logger-for-bungee/commit/9bbe6352fc4b4f06a1870a523775090689b15efa

залил билд:
https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

PabloGirol commented 2 years ago

Looks like the same issue is reproducing on java 17

gomin1d commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

Dymeth commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

The problem is relevant for this release (v1.0.7). Tested on openjdk-16 and the latest build of Leymooo's botfliter (v3.8.8.1) on Windows 10 and Ubuntu 20.

Also, when plugin trying to start, the output of the command entered in the console is turned off (although the execution of commands still works)

Also note that the plugin.yml contains the wrong plugin version (1.0.1-SNAPSHOT)

gomin1d commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

The problem is relevant for this release (v1.0.7). Tested on openjdk-16 and the latest build of Leymooo's botfliter (v3.8.8.1) on Windows 10 and Ubuntu 20.

Also, when plugin trying to start, the output of the command entered in the console is turned off (although the execution of commands still works)

I run successfully on java17
Here's even my test server: BungeeCord.zip Correct the path to your java location in the start.sh file

Dymeth commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

The problem is relevant for this release (v1.0.7). Tested on openjdk-16 and the latest build of Leymooo's botfliter (v3.8.8.1) on Windows 10 and Ubuntu 20. Also, when plugin trying to start, the output of the command entered in the console is turned off (although the execution of commands still works)

I run successfully on java17 Here's even my test server: BungeeCord.zip Correct the path to your java location in the start.sh file

It looks like something works differently in your BungeeCord fork. Everything works correctly on it, however, on the version from Leymooo, the problem described above occurs

gomin1d commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

The problem is relevant for this release (v1.0.7). Tested on openjdk-16 and the latest build of Leymooo's botfliter (v3.8.8.1) on Windows 10 and Ubuntu 20. Also, when plugin trying to start, the output of the command entered in the console is turned off (although the execution of commands still works)

I run successfully on java17 Here's even my test server: BungeeCord.zip Correct the path to your java location in the start.sh file

It looks like something works differently in your BungeeCord fork. Everything works correctly on it, however, on the version from Leymooo, the problem described above occurs

I updated my botfilter, and indeed found the error:

WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
11:50:30 [WARNING] Error loading plugin SpigotLoggerForBungee
java.lang.UnsupportedOperationException: No class provided, and an appropriate one cannot be found.
    at org.apache.logging.log4j.LogManager.callerClass(LogManager.java:555)
    at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:580)
    at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:567)
    at ua.lokha.spigotloggerforbungee.SpigotLoggerForBungeePlugin.onLoad(SpigotLoggerForBungeePlugin.java:51)
    at net.md_5.bungee.api.plugin.PluginManager.enablePlugin(PluginManager.java:344)
    at net.md_5.bungee.api.plugin.PluginManager.loadPlugins(PluginManager.java:250)
    at net.md_5.bungee.BungeeCord.start(BungeeCord.java:297)
    at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:49)
    at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)

Okay, I'll try to fix it today.

PabloGirol commented 2 years ago

Looks like the same issue is reproducing on java 17

Does this release also not work? https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.7

This is the release I have downloaded.

Java Version imagen BungeeCord just downloaded from ci imagen Still happend

PabloGirol commented 2 years ago

Seems like just changing line 51 of SpigotLoggerForBungeePlugin from this.logger = LogManager.getLogger(); to this.logger = LogManager.getLogger(SpigotLoggerForBungeePlugin.class); Seems to resolve my issue

Dymeth commented 2 years ago

OpenJDK 17 BungeeCord BotFilter 3.8.9 (MC 1.18) SpigotLoggerForBungee 1.0.8

WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. [WARNING] Error loading plugin SpigotLoggerForBungee java.lang.UnsupportedOperationException: No class provided, and an appropriate one cannot be found. at org.apache.logging.log4j.LogManager.callerClass(LogManager.java:573) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:598) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:585) at ua.lokha.spigotloggerforbungee.SpigotLoggerForBungeePlugin.onLoad(SpigotLoggerForBungeePlugin.java:51) at net.md_5.bungee.api.plugin.PluginManager.enablePlugin(PluginManager.java:344) at net.md_5.bungee.api.plugin.PluginManager.loadPlugins(PluginManager.java:250) at net.md_5.bungee.BungeeCord.start(BungeeCord.java:295) at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:49) at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)

gomin1d commented 2 years ago

OpenJDK 17 BungeeCord BotFilter 3.8.9 (MC 1.18) SpigotLoggerForBungee 1.0.8

WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. [WARNING] Error loading plugin SpigotLoggerForBungee java.lang.UnsupportedOperationException: No class provided, and an appropriate one cannot be found. at org.apache.logging.log4j.LogManager.callerClass(LogManager.java:573) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:598) at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:585) at ua.lokha.spigotloggerforbungee.SpigotLoggerForBungeePlugin.onLoad(SpigotLoggerForBungeePlugin.java:51) at net.md_5.bungee.api.plugin.PluginManager.enablePlugin(PluginManager.java:344) at net.md_5.bungee.api.plugin.PluginManager.loadPlugins(PluginManager.java:250) at net.md_5.bungee.BungeeCord.start(BungeeCord.java:295) at net.md_5.bungee.BungeeCordLauncher.main(BungeeCordLauncher.java:49) at net.md_5.bungee.Bootstrap.main(Bootstrap.java:15)

fixed https://github.com/lokha/spigot-logger-for-bungee/releases/tag/1.0.9
sorry for the long fix. there was no time