gomita / firegestures

FireGestures, a Firefox extension.
http://www.xuldev.org/firegestures/
Other
127 stars 30 forks source link

Back / Forward History Popup broken #138

Closed gigelu closed 7 years ago

gigelu commented 7 years ago

The Back / Forward History does nothing when clicking any item. I went back to version 1.10.6 to get it working again.

After some debugging, I got to these 2 pieces of code that seem to be the problem: in browser.js line 967:

setTimeout(function() { popup.currentItem = popup.defaultItem || popup.firstChild; }, 10);

and on line 1054:

var item = popup.currentItem || event.target;
if (popup.defaultItem == item)
    break;

popup.currentItem is always the same as popup.defaultItem, so no action is taken when clicking an item in the menu.