search

gomita / firegestures

FireGestures, a Firefox extension.
http://www.xuldev.org/firegestures/
Other
128 stars 30 forks source link

diagonal mouse gestures #7

Open Jonny007-MKD opened 13 years ago

Jonny007-MKD commented 13 years ago

Hello, this isn't really a problem, but I don't find any other way to request a feature. It would be really great, to include diagonal mouse gestures. Until now I used "mozgestures" because they had this feature, but they dropped the project. I think they are wonderful, because you have so much more possibilities to combine gestures.

greetz Jonny007

kubeek commented 13 years ago

This would be very helpful and easy to implement. I am used to using up-right and down diagonal for home/end navigation, and now the gesture works only half of the time, because I either do UR or RU gesutre.

Zetten commented 13 years ago

I've implemented this in a fork at https://github.com/Zetten/firegestures although it's quite hacky and far from polished. Essentially I just read the angle with Math.atan2(dx,dy) and translate that into LRUD for orthogonals and 1379 for diagonals. I also had to add the 1379 characters to the validation regexes, but the overall changes are minimal.

My JavaScript is a bit rusty and I've never done any addon dev stuff before, but it seems to work fairly well. I'm more than happy to help polish it up and flow back up to the distributed addon if requested; I think at the very least it'll need an option to enable/disable diagonals so current users aren't surprised.

bandi423 commented 13 years ago

One of the reasons I like Firegestures is that its gesture recognition is very robust (because it only uses 4 directions) and it allows very quick and easy usage. I think that diagonal gestures would ruin the experience.

Zetten commented 13 years ago

The simplicity is certainly true, and I felt that way at first and tried to force myself to get used to LRUD-only gestures. However, I've had some diagonal gestures ingrained in me from other addons, and simply couldn't adjust.

I think shorter chains are easier to remember, especially when composed of so few directional elements, and adding the diagonals gives you a huge number of available gestures. With just two segments, using LRUD you have 12 possible gestures, but using 1379LRUD there are 56. That said, I tend to only use single-element diagonals and at most two-element orthogonals, which covers 100% of my actual gesturing.

In my pull request (although largely forgotten) I have working diagonal gestures, which are disabled by default, and toggled with a simple checkbox in the options. I think this is the best of both worlds.

MonsieurK commented 13 years ago

Just a little message to say that now Mouse Gesture Redox is really off the race (Jochen definitively ended updates a few days ago, and his extension is not usable with Fx > 7.*), users of MGRedox will want to find an alternate solution. As it was the only one allowing natively the use of diagonal gestures, I think Zetten's implement may be a good solution for people like me, trying to find a replacement. Having it present disabled by default may be the best solution for people that don't feel comfortable with complicated gestures, but that's somehow important for me... I hope it'll be added in the general release of FireGestures (as I'm kinda bored with updating extension from various unofficial sources... it's a nightmare, moreover with the new versionning system used by Mozilla).

By the way, thanks for all your work !

Clydefrosch22 commented 7 years ago

I have no idea what to do with this github stuff, how do I get this addon with diagonal support?