search

gomods / athens-charts

Helm charts for athens
https://gomods.github.io/athens-charts/
MIT License
10 stars 14 forks source link

Support Recommended K8s Labels #44

Closed alex-bezek closed 11 months ago

alex-bezek commented 11 months ago

Currently, this helm chart uses the label app across resources such as here. This works great for the most part, except internally, we have tooling that relies on the Kubernetes recommended labels, specifically app.kubernetes.io/instance.

Would you be open to accepting a contribution that adds this label, or alternatively, add a helm value for passing additional common labels similar to how other helm charts work https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L66

Thank you for the great app and chart, if you are open to either of these options, let me know and I can make a PR!

DrPsychick commented 11 months ago

Hey @alex-bezek, that is an absolute reasonable request, thanks for taking the time to propose it. Please do open a PR and I will review it as soon as I can. Going the route of many other charts seems very reasonable to me as well.

alex-bezek commented 11 months ago

@DrPsychick I've opened a PR that adds in the new labels and allows users to pass in additional labels as well https://github.com/gomods/athens-charts/pull/45 Thanks!