gomods / athens-charts

Helm charts for athens
https://gomods.github.io/athens-charts/
MIT License
10 stars 14 forks source link

fix: don't specify replicas when autoscaling is enabled #68

Closed vyas-n closed 4 months ago

vyas-n commented 4 months ago

Horizontal Pod Autoscalers automatically change the replicas field based on runtime metrics of the application.

This can cause false warnings to appear for folks using GitOps tooling such as ArgoCD because the tool will indicate that the application is out-of-sync due to this field when it actually isn't.

Screenshot 2024-04-19 at 10 50 27 Screenshot 2024-04-19 at 10 50 43

This PR cleans up the deployment object so that it's not marked as Out-Of-Sync