gomods / athens-charts

Helm charts for athens
https://gomods.github.io/athens-charts/
MIT License
10 stars 14 forks source link

Impossible to disable ServiceAccount #69

Closed mxk closed 4 months ago

mxk commented 4 months ago

If serviceAccount.create is set to false, the deployment fails because the Pod spec still ends up with a serviceAccount: {{ template "fullname" . }} attribute. That should probably be conditional.

zoomoid commented 4 months ago

For pre-provisioned service accounts, this breaks the chart's functionality of adding service accounts to the deployment entirely, because in that case we don't want it to create a Service Account but also want to template in the name