The 'athens-proxy' build step in drone should build an Athens image and run it, instead of using the canary image

gomods / athens

A Go module datastore and proxy

https://docs.gomods.io

MIT License

4.43k stars 499 forks source link

The 'athens-proxy' build step in drone should build an Athens image and run it, instead of using the canary image #1481

Open arschles opened 4 years ago

arschles commented 4 years ago

Describe the bug

Since we're using the canary image, we are running the Athens server was built from the previous merge to master. That might be useful, but I think it's more useful to run the current one and test against that.

Error Message

N/A

To Reproduce

N/A

Expected behavior

N/A

Environment (please complete the following information):

N/A

Additional context

N/A

arschles commented 4 years ago

This might be tough to do in drone, since we need to run Athens as a service. Not sure if we could do it in GH actions (https://github.com/gomods/athens/issues/1460) either...

We could possibly build and run an Athens container (we currently only run it as a process in the background) as part of e2e tests (#1474)