search

gomods / athens

A Go module datastore and proxy
https://docs.gomods.io
MIT License
4.41k stars 497 forks source link

Athens/docker on aws EC2 not picking up instance role for S3 Permissions #1703

Open thomasrutkowski opened 3 years ago

thomasrutkowski commented 3 years ago

Describe the bug When running Athens from the official docker container, Athens will not catch the instance role credentials unless AWS_USE_DEFAULT_CONFIGURATION is set to true.

To Reproduce Steps to reproduce the behavior: Add instance role to instance, start athens from docker and set S3 environment without setting any credentials.

Expected behavior Athens should start and pick up the instance role when no other credentials are provided. Since AWS_USE_DEFAULT_CONFIGURATION is slated for depreciation it should work without setting that env var.

Environment (please complete the following information):

thomasrutkowski commented 3 years ago

This isssue is NOT resolved by #1708.

Documentation does not solve the problem that instance roles are only be used when setting a configuration value slated for depreciation as true. #1708 only states to use that config. This is for resolving the underlying problem and should be reopened.

marwan-at-work commented 3 years ago

@thomasrutkowski happy to re-open, although setting the env var seems like a low lift. Any suggestions on how to resolve the underlying problem without having to set the env var?

thomasrutkowski commented 3 years ago

The problem is deprecating the variable. If it stays then by all means, just set it.

No easy fix apparent after a quick look. Will try to dig a bit when I have time.

On 29 Mar 2021, at 01:34, Marwan Sulaiman @.***> wrote:

 @thomasrutkowski happy to re-open, although setting the env var seems like a low lift. Any suggestions on how to resolve the underlying problem without having to set the env var?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.