gomodule / redigo

Go client for Redis
Apache License 2.0
9.76k stars 1.25k forks source link

add a simple example with 3 function 'GetValue' 'SetValue' 'GetKeys' #577

Closed oneleg closed 2 years ago

stevenh commented 3 years ago

Thanks for the PR @oneleg but not sure what the benefit of this is as it doesn't use a typical flow, specifically leveraging a connection pool and is already pretty well covered by docs.

A better way to have concrete examples would via test examples.

oneleg commented 3 years ago

Thanks for the PR @oneleg but not sure what the benefit of this is as it doesn't use a typical flow, specifically leveraging a connection pool and is already pretty well covered by docs.

A better way to have concrete examples would via test examples.

Hi yes I saw the test sample page but I thought it would be easier for others to have a file with functions anyway thanks for response to my request 👍🏻

stevenh commented 2 years ago

Happy to reconsider if it’s updated to use best practices including a pool, but for now closing