search

gomoob / php-pushwoosh

A PHP Library to easily send push notifications with the Pushwoosh REST Web Services.
http://gomoob.github.io/php-pushwoosh
MIT License
65 stars 37 forks source link

setCURLClient documentation wrong #65

Closed fvermeulen closed 7 years ago

fvermeulen commented 7 years ago

This line could be removed right or like the other method in that class you should return the instance.

https://github.com/gomoob/php-pushwoosh/blob/master/src/main/php/Gomoob/Pushwoosh/Client/Pushwoosh.php#L303

bgaillard commented 7 years ago

Hi @fvermeulen and thanks for your response, you're right on this the code should return a reference to the Pushwoosh instance as documented.

Can you create a PR for this ?

Thanks

bgaillard commented 7 years ago

Now the setCURLClient(...) method returns the instance so we can close this issue. This will be integrated in version 1.8.0.