Support for chrome_image

gomoob / php-pushwoosh

A PHP Library to easily send push notifications with the Pushwoosh REST Web Services.

http://gomoob.github.io/php-pushwoosh

MIT License

65 stars 37 forks source link

Support for chrome_image #68

Closed anibalsanchez closed 7 years ago

anibalsanchez commented 7 years ago

chrome_image works perfectly fine, and it's a handy attribute to have it supported.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 99.579% when pulling 8428b3be9c2e5b40bca34470d5912baa681bbfb5 on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

bgaillard commented 7 years ago

Hi @anibalsanchez and thanks for this addition.

To keep high quality standards we would like to have a 100% code coverage. Could you also update the unit tests for your feature ?

Thanks

anibalsanchez commented 7 years ago

Hi, I've just added the test.

coveralls commented 7 years ago

Coverage decreased (-49.8%) to 50.034% when pulling 800b1d075c4311129caa457cf6690e0b1048f93a on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 99.832% when pulling f68179b321ad541c3f3814fc2139e43d76e14abe on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage decreased (-14.0%) to 85.859% when pulling f2763c3604d6df144042351b61d6f8757ee8015b on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage decreased (-14.0%) to 85.859% when pulling f2763c3604d6df144042351b61d6f8757ee8015b on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 99.832% when pulling befff1a2f38fdbe5745be9468c70b43889972118 on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 99.832% when pulling befff1a2f38fdbe5745be9468c70b43889972118 on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 99.832% when pulling befff1a2f38fdbe5745be9468c70b43889972118 on anibalsanchez:master into e5bce6266894e11c52af8f7be13f966da4f9e1fd on gomoob:master.

anibalsanchez commented 7 years ago

Back to 100%