search

gomoob / php-pushwoosh

A PHP Library to easily send push notifications with the Pushwoosh REST Web Services.
http://gomoob.github.io/php-pushwoosh
MIT License
65 stars 37 forks source link

Possibility to filter notification target(s) by user(s) #69

Open Xplouder opened 7 years ago

Xplouder commented 7 years ago

Let me know if the tests are mandatory or just optional.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.581% when pulling 0a49b715de20422e2274db5765474e25f606051c on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

bgaillard commented 7 years ago

Hi @Xplouder and thanks for this new feature.

Let me know if the tests are mandatory or just optional.

Yes, since version 1.8.0 code coverage is 100%, to respect our quality standards we wish to keep 100% code coverage now.

So could you complete the unit tests associated to the Notification class to increase the code coverage ?

Thanks

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

Xplouder commented 7 years ago

@bgaillard Any ETA to get this merged?