gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
754 stars 175 forks source link

Major League Baseball: incorrect intro & title screen #1664

Open gonetz opened 6 years ago

gonetz commented 6 years ago

Title screen: https://cloud.githubusercontent.com/assets/8987490/12509862/ec06b2f2-c105-11e5-9ee4-fe655e54cde4.png

loganmc10 commented 6 years ago

I just tested in mupen64plus with FBInfo:

mlb_featuring_k_g_jr-000

It's broken without FBInfo, and it still flickers between images, but I think angrylion might do that too.

loganmc10 commented 6 years ago

The interesting thing is not even synchronous buffer copies fixes the issue, only FBInfo. I just tested angrylion and it works the same, so basically with FBInfo it works the same as angrylion. I'm not sure about 1964 or mupen64, only tested mupen64plus (with fixed FBInfo, still a PR over there)

gonetz commented 6 years ago

Cool!

gonetz commented 6 years ago

As I remember, the game does not copy background image at one step. Half is copied in one frame another half in another frame. Thus, even sync copy does not help.

AmbientMalice commented 6 years ago

An interesting example of how FBInfo can improve accuracy.

weinerschnitzel commented 6 years ago

Interesting indeed. However, Wouldn't this mean that while in sync copy, the buffer is getting cleared too early before the rest of the contents are copied in?

What does the copy look like when you step through frame by frame with FBInfo?

purplemarshmallow commented 6 years ago

Wouldn't this mean that while in sync copy, the buffer is getting cleared too early before the rest of the contents are copied in?

Maybe, I think sync copies should work in theory. Even if it's not copied in one step. The whole image should still be in a buffer on the gpu at some point

olivieryuyu commented 6 years ago

it is not linked to interleaving somehow?

oddMLan commented 4 years ago

looks similar to https://github.com/gonetz/GLideN64/issues/617#issuecomment-549803363