gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
773 stars 180 forks source link

Finishing HLE - Help needed #1944

Closed olivieryuyu closed 5 years ago

olivieryuyu commented 5 years ago

Hi Guys!

I am about to quench all HLE known bugs. Is there any bug which you may be aware of?

For that you need to compare HLE and LLE with GlideN64 and see if there is difference.

HVQM and SDEX issues does not need to be reported.

If nothing comes up, I will stop my work on HLE deciphering. So please help to find any remaining bugs!

See ya!

oddMLan commented 5 years ago

I've noticed this for a while, but thought it was really minor so I didn't report it.

HLE conkerhle

LLE conkerlle

LLE has dimmer (and much more accurate) lightning.

olivieryuyu commented 5 years ago

Ok CBFD looks a candidate for decoding.

ShareScene commented 5 years ago

maybe this? #1509

loganmc10 commented 5 years ago

Reported from someone on Reddit:

Turok 64, the sun has no lens flare with GlideN64 but does when using angrylion rdp plus.

olivieryuyu commented 5 years ago

where are the lens flare?

Is it the same in LLE with GlideN64?

olivieryuyu commented 5 years ago

maybe this? #1509

Nope

Stajin commented 5 years ago

To add to the reported Turok bug on reddit - here is the link to the post so you can ask the person reporting directly as they don't use Github.

https://www.reddit.com/r/emulation/comments/9z166z/gliden64_dev_asking_for_hle_bugs_to_fix/

Kidboy17 commented 5 years ago

1731 Is this a possible candidate?

Kidboy17 commented 5 years ago

Here is one for HLE only, #1912

Another one, #1736

olivieryuyu commented 5 years ago

1731 Is this a possible candidate?

Nope it is the same in LLE.

olivieryuyu commented 5 years ago

Here is one for HLE only, #1912

OK, weird one...

olivieryuyu commented 5 years ago

Another one, #1736

Nope

ShareScene commented 5 years ago

and... what about Resident Evil 2 ucode? is it completely deciphered?

loganmc10 commented 5 years ago

and... what about Resident Evil 2 ucode? is it completely deciphered?

Yes I believe so, works fully in HLE (https://gliden64.blogspot.com/2017/04/resident-evil-2.html)

fbeuter commented 5 years ago

RE2 works properly now, but if I'm not mistaken, it's still using the same hack from Glide64 to display the backgrounds correctly. The correct behaviour has never been fully deciphered.

loganmc10 commented 5 years ago

Perhaps, but either way that is not a ucode issue (HLE vs LLE)

Tasosgemah commented 5 years ago

nvm, Goemon's Great Adventure seems fine.

oddMLan commented 5 years ago

Guys, olivieryuyu is asking only about issues where HLE looks different/incorrect than LLE mode.

LegendOfDragoon commented 5 years ago

@olivieryuyu would you be interested in HLEing GB Tower in pokemon stadium 2?

olivieryuyu commented 5 years ago

@LegendOfDragoon

if we do speak of a a gfx microcode to implement, I am fine with that. Please give savestate for this for PJ64.

olivieryuyu commented 5 years ago

To add to the reported Turok bug on reddit - here is the link to the post so you can ask the person reporting directly as they don't use Github.

https://www.reddit.com/r/emulation/comments/9z166z/gliden64_dev_asking_for_hle_bugs_to_fix/

Cannot find the bug. Need PJ64 savestate.

LegendOfDragoon commented 5 years ago

if we do speak of a a gfx microcode to implement, I am fine with that.

Technically the task type = 2, but it certainly deals with graphics. It may be like WDC where it deals with both audio and graphics in same task. I tried making a savestate, but it doesn't work. I believe PJ64 has a problem with savestates when using transfer pack in-game.

olivieryuyu commented 5 years ago

@LegendOfDragoon

Just provide a savestate before getting into the screen where the ucode starts.

LegendOfDragoon commented 5 years ago

@olivieryuyu PJ64 seems to clear the transfer pack data when loading a save state. I guess you can hold off on it until this issue is fixed. I may look into fixing it next weekend. I even made a savestate at the game pack check screen and there's no game pack when loading the save state.

olivieryuyu commented 5 years ago

To add to the reported Turok bug on reddit - here is the link to the post so you can ask the person reporting directly as they don't use Github. https://www.reddit.com/r/emulation/comments/9z166z/gliden64_dev_asking_for_hle_bugs_to_fix/

Cannot find the bug. Need PJ64 savestate.

Found where it is but it works in LLE and HLE without any issue.

gliden64_turok_dinosaur_hunte_000

olivieryuyu commented 5 years ago

Holy Moly, Conker lighting is quite something. There is not one but actually two lighting modes!

Frank-74 commented 5 years ago

There's still Stunt Racer 64 and World Driver Championship to be HLE'd... Only then can Finishing HLE be possible...

loganmc10 commented 5 years ago

@Frank-74 that is already done

Frank-74 commented 5 years ago

@loganmc10 Has it? I still get RunRSP error on booting WDC with HLE Gfx in Project64. Using latest WIP GLideN64.

ShareScene commented 5 years ago

it was implemented long time ago by Gillou68310

ShareScene commented 5 years ago

https://github.com/gonetz/GLideN64/pull/1717

Frank-74 commented 5 years ago

Well, WDC LLE Gfx boots fine with latest GLideN64 WIP. Choosing HLE Gfx results in RunRSP error. How do I get it to run HLE gfx with Project64?

LegendOfDragoon commented 5 years ago

@Frank-74 i think it only works in mupen64plus.

theboy181 commented 5 years ago

At this point mupen is the emulator of the future. They have been adding hacks to get their games running so that development for GLideN64 can continue. At the time this game was added to their comparability list more contributions were added to the puzzle from their developers.

loganmc10 commented 5 years ago

It wasn't any kind of hack that allowed World Driver Championship to work with HLE, we extended the gfx_info API to include SP_STATUS_REG, that is what was needed for WDC and Stunt Racer:

https://github.com/mupen64plus/mupen64plus-core/pull/423

If PJ64 did something similar then those games would work in HLE

theboy181 commented 5 years ago

I’m sorry. I did t realize that that’s how the real hw worked. What about gauntlet then? Hack?

loganmc10 commented 5 years ago

Gauntlet Legends was a similar situation, the GFX plugin needs to be able to modify the SP_STATUS bit.

It's not really a matter of hack/no hack. Because of the plugin system, the GFX plugin didn't have the ability to modify all of the RSP registers, it was a shortcoming of the original API design many years ago

olivieryuyu commented 5 years ago

Guys, this is getting off topic. Can you please provide HLE bugs? Conker deciphering is already started. Mario Party should next. Anything else?

schubertguilherme commented 5 years ago

Hello, olivieryuyu, slowdown game Mortal Kombat Trilogy in stage "The Subway" and bug graphics in Top Gear Hyper Bike "textures". Fix please. Hugs and sucess.

olivieryuyu commented 5 years ago

Hello, olivieryuyu, slowdown game Mortal Kombat Trilogy in stage "The Subway" and bug graphics in Top Gear Hyper Bike "textures". Fix please. Hugs and sucess.

Nothing to do with HLE.

theboy181 commented 5 years ago

The stage in hyper bike? What is the issue then?

Frank-74 commented 5 years ago

Top Gear Hyper Bike is same bug with ground textures in LLE and HLE with GLideN64. But Angrylion gets it right.

olivieryuyu commented 5 years ago

Conker nearly over. Anything else?

StenApp commented 5 years ago

Is there a list of non HLE related errors? I lost the overview of what is what type of problem

olivieryuyu commented 5 years ago

Nothing else ?

ShareScene commented 5 years ago

I think u should take a look Resinde Evil 2, because ucode is not totally deciphered... instead of that is totally hacked.

olivieryuyu commented 5 years ago

There is no ucode issue with RE2.

GamingTVYT commented 5 years ago

@schubertguilherme What is the WIP you are using, please? I'm going to test here to see if the same error occurs.

olivieryuyu commented 5 years ago

Again this has nothing to be with HLE. Please stop using this issue for non HLE issue!

Kidboy17 commented 5 years ago

Issue #1484 ? Even though it uses per pixel lighting, the issue is only in HLE mode.

Issue #1803 which leads to issue #1647 ?