gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
775 stars 180 forks source link

HDR10 Support for fullscreen #1962

Open theboy181 opened 5 years ago

theboy181 commented 5 years ago

When I have my desktop set to HDR and I switch to fullscreen the screen has to change, and turn off HDR mode.

Would it be possible to add HDR10 feature for fullscreen? This would eliminate the time it takes when switching between window modes and fullscreen modes.

Jj0YzL5nvJ commented 5 years ago

Wanting to use a sledgehammer to crack a nut?

Quick question: Does such behavior occurs on m64p too or is it exclusive of PJ64?

I don't have HDR10's capable hardware, so I can't try myself. m64p don't use exclusive mode in XFCE4 and I pretty sure it don't use such on Win7 too, so...

gonetz commented 5 years ago

Would it be possible to add HDR10 feature for fullscreen?

I did not find how to do it with OpenGL. If it can be done with some simple steps in GL context creation, it can be added. If something more complex is required, like use of floating point frame buffers, it hardly will be implemented.

Jj0YzL5nvJ commented 5 years ago

The problem described by @theboy181 is pure exclusive vs noexclusive mode, very similar to #1852 Example of non-exclusive mode gaming: https://youtu.be/HD54b8ZVS3E?t=18m14s

How to play HDR videos on a HDR screen? native 10 bit output for MS Windows 10 1709 and above (or possibly Windows 7 and above)

theboy181 commented 5 years ago

Thanks for pointing this out.

kathampy commented 5 years ago

SDR applications should look fine in HDR mode if you configure the "SDR content appearance" slider to your desired brightness. On G-SYNC HDR monitors, the desktop and SDR content looks identical whether HDR is on or off. The exception would be TVs which dynamically alter the image in HDR mode resulting in sub-optimal SDR presentation. Disabling dynamic contrast / tone mapping on the TV in HDR mode, and using a PC mode if available should result in identical SDR content appearance whether HDR is on or off. On some TVs this may be impossible, necessitating the the need for fullscreen exclusive mode which switches off HDR for SDR content.

LuismaSP89 commented 2 years ago

In other emulators such snes9x the problem with HDR happens too, but it was solved by using the "emulated fullscreen" option they implemented in the emulator options. With this you can use a borderless fullscreen and the HDR issue was gone.

I posted the same issue for Gliden64, but seems a bit difficult to implement:

https://github.com/gonetz/GLideN64/issues/2518