search

gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
774 stars 180 forks source link

Mario Golf: Animated effects render in front of course #2577

Closed ghost closed 3 years ago

ghost commented 3 years ago

This issue is back again: #312

tested on mupen ae latest, project 64 latest and mupen64plus latest

issue does not exist on mupen64plus latest,

something interesting , it seems enabling n64 depth compare solves the original issue but enabling it creates a new issue where the player model and water and other things are rendered/unrendered as you move the camera, its like the same problem just switches to affect other assets while fixing the original

ghost commented 3 years ago

@fzurita does the issue also happen on your phone with the latest mupen ae, latest Gliden64 and most accurate Gliden64 settings ? if you go to training mode and keep pressing right and select hole 4, its most visible there the rendering issue (the water)

fzurita commented 3 years ago

I'll try it soon, I've been busy with other things.

fzurita commented 3 years ago

Yeah, I definitely see the issue. Polygons are rendering on front of pre-rendered backgrounds. If you move the camera around, the course is no longer pre-rendered, so depth works correctly.

Not sure what broke it...

ghost commented 3 years ago

Hopefully since it was fixed before, it will be easy enough to understand whats happening, maybe gonetz could take a look if he has some free time.

gonetz commented 3 years ago

Bisected to a405ad8659 and 4834359ec1a a405ad8659 - the game does not work because of error with shader compilation. 4834359ec1 - the game works, but with the regression

ghost commented 3 years ago

interesting, i wonder if there are other regressions in other games that nobody has noticed that will also be fixed also by this

gonetz commented 3 years ago

Hardly. It is quite specific case.

ghost commented 3 years ago

Thanks gonetz ! :)

gonetz commented 3 years ago

It's not the only regression with Mario Golf. Currently background image shifted by a pixel when camera stops moving. It causes some distortions in the image. I'm trying to find, when that issue was introduced.