search

gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
770 stars 177 forks source link

Tex load refactor #2650

Closed gonetz closed 2 years ago

gonetz commented 2 years ago

Refactor texture load: apply proper mask to tmem read address to prevent out of bounds reads.

GhostlyDark commented 2 years ago

Ocarina of Time and AeroFighters Assault look fine. GoldenEye still shows black textures.

gonetz commented 2 years ago

GoldenEye still shows black textures.

I can't reproduce these black textures in GoldenEye. master build (before that fix) also works ok. Please try to disable shader cache or delete *.shaders files and reset plugin settings to defaults.

GhostlyDark commented 2 years ago

I can't reproduce these black textures in GoldenEye. master build (before that fix) also works ok.

I had mip-mapping turned off. Activating it fixes the walls. There are black textures in the menu after aborting a mission, but that happened before the fix as well. So it's unrelated. My bad.

gonetz commented 2 years ago

I had mip-mapping turned off. Activating it fixes the walls.

Yes, walls are black with mip-mapping turned off. It should not be so.