gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
762 stars 175 forks source link

Transparent textures in Densha De Go #2663

Closed danepowell closed 2 years ago

danepowell commented 2 years ago

Out of the box, running Densha De Go in Mupen64Plus-Next in Retroarch with Gliden64 plugin, almost all of the textures in the game are transparent. Disabling legacy blending seems to fix this.

Can we add generalEmulation\enableLegacyBlending=0 to GLideN64.custom.ini for this game? I'm happy to open a PR if this is the right approach.

gonetz commented 2 years ago

enableLegacyBlending is off by default. Do you have other defaults with Retroarch? Legacy blending is mostly for old GLES2 and GLES3 devices.

danepowell commented 2 years ago

Interesting. I am using default settings, and yet legacy blending is enabled. I wonder if this is a bug in mupen64plus-libretro-nx?

I'm using the gles3 core, which is the only one available via Rotroarch on Android. Looking at the config, it looks like the default should be disabled, and yet in reality it's enabled. Here's the commit I'm running on my Shield: https://github.com/libretro/mupen64plus-libretro-nx/blob/018ee72b4fe247b38ed161033ad12a19bb936f00/GLideN64/src/Config.cpp#L47

I'll attach the default settings on this device where you can see that legacy blending is enabled. Mupen64Plus-Next.default.opt.txt

Edit: I confirmed that legacy blending seems to be the only "rogue" settting not picking up the correct default.

gonetz commented 2 years ago

I guess that settings from Mupen64Plus-Next.default.opt.txt override GLideN64 defaults. You may ask Retroarch, why they made legacy blending enabled by default. May be there were complains on performance.

Can we add generalEmulation\enableLegacyBlending=0 to GLideN64.custom.ini for this game? I'm happy to open a PR if this is the right approach.

Yes, we can. Please open a PR.