gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
762 stars 175 forks source link

Fix #2663: Transparent textures in Densha De Go #2670

Closed danepowell closed 2 years ago

danepowell commented 2 years ago

I'm not sure that these are the right ROM names. I understand that for Japanese roms, the CRC is used as the name. But when I checked all of the other Japanese ROM names in this file, none of them matched any official CRCs that I could find in an actual ROM or db.

Additionally, a full CRC is 8 bytes, but the names in the ini file are 4 byte strings. I'm not sure where those 4 bytes come from?

gonetz commented 2 years ago

I'm not sure that these are the right ROM names. I understand that for Japanese roms, the CRC is used as the name. But when I checked all of the other Japanese ROM names in this file, none of them matched any official CRCs that I could find in an actual ROM or db.

Japanese ROM name can't be used directly because Japanese symbols are obviously not ASCII, and reading such symbols is locale-dependent. Thus, plugin calculates Adler32 checksum of ROM name bytes. This checksum is the rom name.