gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
762 stars 175 forks source link

Texture Pack Path For WCW / nWo Revenge Not Sanitized #2676

Closed flagrama closed 2 years ago

flagrama commented 2 years ago

WCW / nWo REVENGE is the internal name of the game. At least on Project64, the / is not properly sanitized so only a folder called WCW gets created while trying to dump textures. This likely also causes an issue for loading textures. Rice format packs exist for the game which seem to sanitize the / to a - but weren't tested with GLideN64.

This seems to be the only game released with an internal name with this character. Modifying the internal header to change the / to a - also worked, but is not very viable for distributing texture packs.

Found out this behaviour with @Oran26thRTI on the project64 discord.

gonetz commented 2 years ago

Yes, currently only ':' is replaced by '-' in a rom name. I uploaded fix 5b8f3e4a82a5, which does the same for '/'. Enhanced and HD textures should work for this game now.

flagrama commented 2 years ago

I'm pretty sure this is good now so I'll go ahead and close this. If Oran26thRTI has issues I'm sure he'll leave a comment.