gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
762 stars 175 forks source link

Dumped textures slightly deviate in colors from actual textures in a game. #2677

Open MelonSpeedruns opened 2 years ago

MelonSpeedruns commented 2 years ago

When dumping textures with GlideN64, the resulting .PNG textures have slightly different colors than if youi dump them directly from the ROM. Attached is 2 textures from Ocarina of Time (1.0 US). One from GlideN64, and one from the game ROM itself

GlideN64: gliden64

From the ROM: hylian_shield_design rgba16

Jj0YzL5nvJ commented 2 years ago

mupen64plus/mupen64plus-user-issues#730 project64/project64#2084

GhostlyDark commented 2 years ago

mupen64plus/mupen64plus-user-issues#730 project64/project64#2084

The RSP decodes JPEG images. If the RSP decodes JPEG files differently than another RSP, the same background dumps with a different hash. None of this applies to non-JFIF textures, as they get dumped visually the same and with the same hash regardless of what RSP is being used. This has nothing to do with the dumps looking different from in-game assets.

Both dumps are byte-wise equal.

HLE RSP hle

Static Interpreter cxd4

(Sidenote: JPEG images after being dumped always look noticeably worse than the original ROM asset.)