gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
754 stars 175 forks source link

Compiling with NOHQ is broken due to out of date header sigs #2705

Closed rishooty closed 1 year ago

rishooty commented 1 year ago

When NOHQ=On in builds newer than the 2019 public release, the project finishes building but the app crashes with fatal errors along the lines of "symbols for 'txfilter_hirestex' (or related methods) not found".

I've ironically, just began learning C after having not touched its younger brother C++ since my first years in college (I'm primarily a webdev). I brushed up on how header files and prototypes worked.

As a result, I noticed that ctlr+clicking a good portion of the method sin TxStub.cpp didn't lead to anything, and that was because their prototypes/signatures have a lot more arguments than they used to. I'll be including a PR soon.