search

gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
754 stars 175 forks source link

Update node.js version 12 to version 16 in CI/CD workflow #2720

Closed bladeoner closed 1 year ago

bladeoner commented 1 year ago

Under the CI/CD runs you see that node.js version 12 is deprecated, this commit uses version 16 instead.

Example of the deprecation warning: https://github.com/gonetz/GLideN64/actions/runs/3354777758

gonetz commented 1 year ago

Linux build failed. I'll revert that PR to see if it is related.

gonetz commented 1 year ago

Hmm, the issue with Linux E: Package 'qt5-default' has no installation candidate seem to be unrelated to this PR. Probably GitHub changed setup for its Linux vms. @Rosalie241 do you know, what can cause that error? Your RMG has successfully built under Linux.

bladeoner commented 1 year ago

@gonetz I had a succesful build at the time I opened the PR: https://github.com/bladeoner/GLideN64/actions/runs/3461028709

Rosalie241 commented 1 year ago

Hmm, the issue with Linux E: Package 'qt5-default' has no installation candidate seem to be unrelated to this PR. Probably GitHub changed setup for its Linux vms. @Rosalie241 do you know, what can cause that error? Your RMG has successfully built under Linux.

I had that error too with RMG, seems like the package got renamed to qtbase5-dev which works fine.