gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
771 stars 179 forks source link

mupen64plus CLI: Fullscreen mode errors #2736

Closed GhostlyDark closed 1 year ago

GhostlyDark commented 1 year ago

Depending on the resolution of the mupen64plus window, the resizing in fullscreen mode fails.

How to reproduce: Going into fullscreen from a 1600x1200 window works fine. Maximizing the window first and then going into fullscreen doesn't resize the screen properly. image

The following errors are printed by GLideN64 (various resolutions tested):

GLideN64/src/Graphics/OpenGLContext/mupen64plus/mupen64plus_DisplayWindow.cpp:211,ERROR, "Error setting videomode 1024x768 in fullscreen mode"
GLideN64/src/Graphics/OpenGLContext/mupen64plus/mupen64plus_DisplayWindow.cpp:211,ERROR, "Error setting videomode 1606x1251 in fullscreen mode"
GLideN64/src/Graphics/OpenGLContext/mupen64plus/mupen64plus_DisplayWindow.cpp:211,ERROR, "Error setting videomode 3840x2160 in fullscreen mode"

The following errors are printed by mupen64plus-core:

Core Error: VidExt_ResizeWindow() called in fullscreen mode

Angrylion-Plus and Parallel don't produce any core errors like shown above.

gonetz commented 1 year ago

I can't reproduce it on my PC. I tested it with old version of mupen64plus (Jan 14 2019). I set video general to 1600x1200, run a game, maximized the window and then switched to full-screen. No problems with video resize.

GhostlyDark commented 1 year ago

I should have specified: Using current master, not the latest release.

There are automated builds of the CLI version available here: https://bitbucket.org/ecsv/mupen64plus-mxe-daily/downloads/

gonetz commented 1 year ago

Sorry, I tested with mupen64plus-gui. Yes, mupen64plus with CLI has that problem. Since mupen64plus-gui switches from maximized window to fullscreen without issues, it is probably a core problem. "videomode 1606x1251" looks suspicious.