Glover (Background image problem)

[roioros]

There is a problem with "Glover", the background image is not displayed correctly using the latest version available ------> GLideN64-7bbde56.

I had also tried some previous versions and the same thing happened but in the Public Release 4.0 this problem does not appear.

Here are some examples of what I'm talking about:

Something interesting that I found is that if we activate the option that says "enable inaccurate texture coordinates" it improves a bit, but it still looks incorrect:

[Nes-player4Life]

PR 4.0 Roioros is correct

[Jj0YzL5nvJ]

Looks good with **rsp-cxd4* and rsp-parallel** (LLE mode).

[roioros]

Is there a way to make it work correctly in HLE, like before?

Thanks.

[gonetz]

Is there a way to make it work correctly in HLE, like before?

Thanks.

Yes. PR created.

[gonetz]

Note: regression commit is 7d237650ef34

It seems that Glover uses slightly different implementation of Sprite2D microcode. Commit 7d237650ef34 improved Wipeout and Silicon Valley, but broke Glover. Ucode description is the same for all three games: "RSP SW Version: 2.0H, 02-12-97" May be @olivieryuyu find time to investigate it? It's not urgent. I just wonder, if the changes are deeper than just decrease of texture coordinates.

[roioros]

Fantastic, thank you so much gonetz for the fix, you're great!

[gonetz]

PR landed. Ready for test.

[olivieryuyu]

@gonetz

i don't see differences at ucode level.

However you should be careful with the limitation of the Sprite microcode.

    _if (GBI.getMicrocodeType() == F3D_Glover) {
        lrs -= 1.0f;
        lrt -= 1.0f;
    }_

seems a bit this limitation:

These filtering conditions also mean that, when displaying a Y-scaled image, you will need to add 1 to the T value to prevent filtering of texels outside the range

http://n64devkit.square7.ch/n64man/ucode/gspSprite2D.htm

[olivieryuyu]

@gonetz

see above

[gonetz]

These filtering conditions also mean that, when displaying a Y-scaled image, you will need to add 1 to the T value to prevent filtering of texels outside the range

Very good note, thanks! I corrected the fix.