search

gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
754 stars 174 forks source link

Change copyToRDRAM default when building with M64P_GLIDENUI #2835

Closed Rosalie241 closed 2 months ago

Rosalie241 commented 2 months ago

Should fix all corruption when resizing the window for all games, because some users were still experiencing this issue

GhostlyDark commented 2 months ago

Should this really be specific to M64P_GLIDENUI instead of being the default in general? Some games need it in the first place (which comes into play when per-game settings are turned off), though I have no idea how much it would impact performance out of the box.

Rosalie241 commented 2 months ago

Should this really be specific to M64P_GLIDENUI instead of being the default in general? Some games need it in the first place (which comes into play when per-game settings are turned off), though I have no idea how much it would impact performance out of the box.

I'm not sure, but the performance impact question is why I limited it to M64P_GLIDENUI

gonetz commented 2 months ago

I have no idea how much it would impact performance out of the box.

The impact is noticeable for games running in Hires mode, that is with internal resolution above 320x240. I'd prefer to enable sync mode via custom game ini for safety. However, if Rosalie thinks that it should be default mode for M64P_GLIDENUI, ok.

Rosalie241 commented 2 months ago

if users will start complaining about worse performance when I release a new version, I'll consider reverting it, but we'll see for now, thanks for merging it! :heart: