gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
754 stars 174 forks source link

2D images misalignment #800

Open gonetz opened 8 years ago

gonetz commented 8 years ago

Large 2D images (e.g. backgrounds) rendered with TexRect command often have alignment issues between parts of the image. Example: gliden64_mariokart64

AmbientMalice commented 8 years ago

I'm assuming this somewhat more drastic alignment problem is related? https://github.com/gonetz/GLideN64/issues/471

c679e270-f0f4-11e4-9499-d13667380d73

edit: Nope, doesn't seem to be.

gonetz commented 8 years ago

Fix in fix_2D feature branch: https://github.com/gonetz/GLideN64/tree/fix_2D

Details: http://gliden64.blogspot.ru/2015/11/improved-2d-and-other-fixes.html

Binaries to test: https://drive.google.com/file/d/0B0YqMPjGo3B2dm8wdXdPRkxxbDg/view?usp=sharing

gonetz commented 8 years ago

Yes Rocket is related, but not fixed by this fix. I'll check why.

AmbientMalice commented 8 years ago

Yes Rocket is related, but not fixed by this fix. I'll check why.

On the bright side, it's not just Rocket affected by that particular misalignment "look", so if that bug is fixed, it'll identical squash texture bugs in a bunch of other games, too.

gonetz commented 8 years ago

I suppose that Rocket has a specific bug, otherwise it would be fixed as well.

AmbientMalice commented 8 years ago

Anyhow, @gonetz, it's a really good bit of coding you've done. It's a huge visual improvement.

purplemarshmallow commented 8 years ago

Conker's BFD does not like this feature. The minimap is broken. The circles are not round. During scenes with a lot of text performance drops below fullspeed. I'll do more testing. gliden64_conker_bfd_000 gliden64_conker_bfd_001

gonetz commented 8 years ago

I forgot to mention: Pokemon Stadium 2 is incompatible with that technique.

gonetz commented 8 years ago

2D in Rocket does not use bilinear filtering. The new drawing method applied only to filtered textures. Unfiltered textures must be aligned. So, this is really specific bug.

purplemarshmallow commented 8 years ago

In OOT some items are invisible. I put the lens of truth on the right c button but it's invisible. gliden64_the_legend_of_zelda_004

purplemarshmallow commented 8 years ago

Super smash bros many images are missing gliden64_smash_brothers_000

purplemarshmallow commented 8 years ago

F-Zero X gliden64_f-zero_x_000

gonetz commented 8 years ago

Thanks! I'll look is it possible to fix.

gonetz commented 8 years ago

Please give me save for Super smash bros.

purplemarshmallow commented 8 years ago

SSB: https://drive.google.com/file/d/0B7Y6r4SpC_QQa09sdjYzRklXTmM/view?usp=sharing

Rayman 2 all 2D is missing gliden64_rayman_2_000

LuigiBlood commented 8 years ago

Mario Artist Paint Studio still fails with transparency with black (also the stamps that clearly is still not working right as it overlays the screen with white). I should note 2D fix didn't change anything. It was like this before. gliden64__001

I also notice that setting the plugin while emulating makes it very buggy, loses all textures for no reason unlike older versions.

(I also suggest trying Mario Artist for testing features related to frame buffer because it overuses that stuff.)

gonetz commented 8 years ago

All known graphics issues fixed. Performance issues are possible, if you have weak hardware. Thanks purplemarshmallow for testing.

Updated binaries: https://drive.google.com/file/d/0B0YqMPjGo3B2WmtmalVFOEJCSGc/view?usp=sharing

purplemarshmallow commented 8 years ago

Glover has depth problems and black borders savestate: https://drive.google.com/file/d/0B7Y6r4SpC_QQZTIwcllNMjJRQ0U/view?usp=sharing gliden64_glover_002

purplemarshmallow commented 8 years ago

Pokemon Stadium 2 boxes are black gliden64_pokemon_stadium_2_009 gliden64_pokemon_stadium_2_014

purplemarshmallow commented 8 years ago

Top Gear Overdrive intro. At the snowblind studios logo it runs very slow I get 8 VI/s. The snow kills performance.

gonetz commented 8 years ago

Wow, you're fast in bugs hunting! :)

Yes, if frame uses lots of separate texrects, it will work slow.

I'll check other issues. Thanks!

LuigiBlood commented 8 years ago

Mario Artist Polygon Studio Regular GLideN64 (2015/10/12) [I should mention that's the one I use regularly]: polymenu_1 GLideN64 2Dfix2: polymenu_2

There's also missing graphics in Talent Studio.

By the way should I make several issues for each Mario Artist games or should I do all-in-one? There are still bugs to begin with.

EDIT: Just tested a master build from 2015/11/14. Actually that bug is also there. So nevermind about 2Dfix. EDIT2: However most 2D graphics aren't visible in 2Dfix2.

gonetz commented 8 years ago

By the way should I make several issues for each Mario Artist games or should I do all-in-one? There are still bugs to begin with.

Please open a ticket for this regression bug. Other issues with this game can be described in another single ticket.

ghost commented 8 years ago

Great bugfix! Excitebike 64 was unaffected by the changes though. gliden64_excitebike64_000 There are a few more alignment issues in the intro and main menu. Savestate in the main menu: https://drive.google.com/file/d/0B8aIJkrbGl-zVXZHN3NxZzhfaEU/view?usp=sharing

gonetz commented 8 years ago

Excitebike 64 needs this fix from master: https://github.com/gonetz/GLideN64/commit/f7ee508c94fabd3485377c3bb0fd82758f37afba

I'll merge it to the next build.

gonetz commented 8 years ago

Fixed all reported issues.

New binary: https://drive.google.com/file/d/0B0YqMPjGo3B2TG5GQkQtZWM3UE0/view?usp=sharing

MelonSpeedruns commented 8 years ago

In Ocarina of Time, the HUD textures seems to render more blurry than usual. Probably rendering at a smaller size?

gonetz commented 8 years ago

Yes, small objects look worse than with usual method, not sure why. They look worse with software render as well. Comparison screen shot: GLideN64 with regular texrect drawing - new drawing method - software lle hearts

ghost commented 8 years ago

gliden64_ogrebattle64_000

Ogre battle backgrounds still render wrong. I don't know if the sprites not matching might be related. Savestate; https://drive.google.com/file/d/0B8aIJkrbGl-zNW9Jd0lYaHhseVk/view?usp=sharing

gonetz commented 8 years ago

Problem with sprites is not related to this feature. The feature fixes only texrects. Sprites are not texrects.

ghost commented 8 years ago

gliden64_marioparty3_000 Mario Party 3 has been broken. Maybe this changes had something to do with it.

gonetz commented 8 years ago

It's very possible.

gonetz commented 8 years ago

Updated binary: https://drive.google.com/file/d/0B0YqMPjGo3B2bUhkR1ZWYi0tYjA/view?usp=sharing

theboy181 commented 8 years ago

What's updated?

Sent from my iPhone

On Nov 28, 2015, at 11:46 AM, Sergey Lipskiy notifications@github.com wrote:

Updated binary: https://drive.google.com/file/d/0B0YqMPjGo3B2bUhkR1ZWYi0tYjA/view?usp=sharing

— Reply to this email directly or view it on GitHub.

LuigiBlood commented 8 years ago

Mario Artist Talent Studio has no menu visible in the talent mode (top mode in the main menu). It was like this before (only on 2Dfix).

ghost commented 8 years ago

MP3 issue fixed.

AmbientMalice commented 8 years ago

As a side effect, likely of https://github.com/gonetz/GLideN64/commit/1580aa040d6e389a3dc33dc84ce190d59a9ce903, the black lines in issues such as https://github.com/gonetz/GLideN64/issues/450 have been half-fixed. Not perfect, because they're sometimes visible, but the alignment is better.

gliden64_tetrisphere_001

I did notice a problem, however. The text in 40 Winks, another game with black lines tends to be cut off at end right hand side, and I'm 99% sure it didn't do that before.

gliden64_40_winks_001

The FOUN will flash and then turn to FOUND and then back again over a few seconds.

SwinglesMan commented 8 years ago

Thanks for this. It even improves speed when using texture filtering options like smoothing 4 and x2. However, anything used from that section still cause lag spikes. Way less than before, but it still happens.

Also, 4K doesn't seem to give errors anymore :)

oddMLan commented 8 years ago

oh oh2

Conker's BFD is affected, too.

SwinglesMan commented 8 years ago

Killer Instinct Gold as well. VS screen, characters get divided into sections. And while fighting, Heads can get chopped off.

frankyfife commented 8 years ago

Super Mario 64 give me some strange font errors with the plugin provided up above (the pre-fix version too). PJ64 2.2.0.9999, RSP Interpreter by Iconoclast, Azimer XA2 WIP6, NRage 2.4. Exept a custom resolution set by me all settings r vanilla.

gliden64_super_mario_64_001 gliden64_super_mario_64_000

theboy181 commented 8 years ago

I noticed this weird character bug on MK64 too. If you full screen and return it will display normally. Does it display properly if you switch to full screen and back?

frankyfife commented 8 years ago

Tried that, but nothing changed. With jabos direct3d 8 plugin everything is fine.

gonetz commented 8 years ago

@AmbientMalice @oddMLan @frankyfife I can't reproduce the issues you reported. Do you use NVidia cards?

@SwinglesMan I can reproduce KI problem, thanks

frankyfife commented 8 years ago

@gonetz - yes, i use an gtx 980Ti nvidia card

gonetz commented 8 years ago

Anybody with ATI or Intel graphics - please test issues with missing last character in CBFD and 40 winks. SM64 issue also does not reproduced on my ATI card.

weinerschnitzel commented 8 years ago

SM64 pre-level text is invisible on Intel, it is visible for maybe 1 frame, then disappears. Pause menu text looks fine, but some textures flash/flicker. (U)[!] version. Conker's BFD text is readable. 40 Winks last letter OK.

baptiste0602 commented 8 years ago

I can't reproduce CBFD, 40 Winks or SM64 bug, everything is OK for me. I have a Nvidia card (GTX670) with latest drivers (359.06).

oddMLan commented 8 years ago

I actually have an AMD Radeon R7 200, so I don't think this issue is vendor-exclusive.

gonetz commented 8 years ago

Ok, it's not vendor specific, good. Please reset settings to defaults, set shades cache off and test again.