gonewandering / angles

An angular.js wrapper for Chart.js
MIT License
632 stars 87 forks source link

Update Readme.md #63

Closed koningskristof closed 9 years ago

koningskristof commented 9 years ago

It seems that type is not in the scope bindings of this directive.

So I updated the examples, since they are not working.

Or you can change the directive to add it to the bindings. That is your choice what you prefer ...

Also I would prefer that if ($scope.chart) { type = $scope.chart; } should be extended that type has a fallback value, like line chart. So that the code will not crash if type is not set.

gonewandering commented 9 years ago

Thanks Kristof