search

gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

Performance #2

Closed hkjels closed 6 years ago

hkjels commented 6 years ago

There's a performance degradation for almost every operation after activating dimmer

gonewest818 commented 6 years ago

Can you share your .emacs.d ? I’m not seeing the same degradation, but based on your comment in #1, I also don’t use the same packages.

hkjels commented 6 years ago

Sure https://github.com/hkjels/.eyre/

gonewest818 commented 6 years ago

Thanks. I ran a quick profile and found a bunch of redundant calculations. It's computing the dimmed versions of the same faces over and over again. So first of all, I'm going to lazily cache the dimmed faces because it's deterministic and there are a finite set of faces. After that I'll try to test with your config.

gonewest818 commented 6 years ago

Try pulling from the master branch. I sort of have your Eyre config installed here, but I'm pretty hopelessly lost with your keybindings so I'm not able to learn much that way. But as I said, I did some optimizations and found at least one performance related bug, so my hope is the experience is better now.

hkjels commented 6 years ago

Emacs is now back to normal in terms of performance. I didn't even know I wanted a package like dimmer until I stumbled onto it. This is really great!

gonewest818 commented 6 years ago

Great! Thanks for being an early adopter and sending the big reports and feedback.

On Dec 6, 2017, at 3:09 AM, Henrik Kjerringvåg notifications@github.com wrote:

Emacs is now back to normal in terms of performance. I didn't even know I wanted a package like dimmer until I stumbled onto it. This is really great!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.