search

gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

specify group instead of requirement for minor mode definition #47

Closed pedrormjunior closed 3 years ago

pedrormjunior commented 4 years ago

It seems the idea of using :require tag is not to require itself. When requiring itself, as before this modification, by changing dimmer-mode through Easy Customization Interface, it creates the line

 '(dimmer-mode t nil (dimmer))

for custom-set-variables. It causes error [1] when dimmer is still not installed (when it will be installed later on, e.g., through package-install-selected-packages).

By avoiding dimmer to require itself, the following line is inserted along with custom-set-variables through Easy Customization Interface:

 '(dimmer-mode t)

which allows the initialization process just fine even when dimmer is not installed yet.

[1] Error:

Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "dimmer")
  require(dimmer)
  mapc(require (dimmer))
  custom-theme-set-variables(user ...)
  apply(custom-theme-set-variables user (...))
  custom-set-variables(...)
  ...
gonewest818 commented 3 years ago

Thanks for this, and sorry about the delay in reviewing!