search

gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

A few little fixes & tweaks #5

Closed purcell closed 6 years ago

purcell commented 6 years ago

Thanks for dimmer - it's very promising! Here's a bunch of little changes, most notably conversion into a global minor mode so that its usage is more idiomatic, and a change to avoid remapping potentially large numbers of non-visible buffers.

gonewest818 commented 6 years ago

Thank you for all this work! The minor mode was on my mental "to-do" list, and the fixes for non-idiomatic code are informative/instructional for me.

gonewest818 commented 6 years ago

Note also - I just added a LICENSE.md and some explicit copyright info into the package header and the readme. This isn't an attempt to take credit for your work ... but I wasn't prepared for contributors so soon, so I need to understand what's best.

I notice CIDER, for instance, does a "Copyright (C) ... and CIDER contributors". I'm inclined to follow this precedent as it is simple.

Thoughts?

purcell commented 6 years ago

I notice CIDER, for instance, does a "Copyright (C) ... and CIDER contributors". I'm inclined to follow this precedent as it is simple.

Not sure it makes much difference tbh. I'm happy to assign copyright to you for any of these minor contributions, so I would just leave your name in there, personally.

gonewest818 commented 6 years ago

Merged. Thanks again for your contributions!

purcell commented 6 years ago

Happy to help! The only little quirk I've noticed is that when the current buffer is visible in multiple windows of the current frame, all are non-dimmed. Seems like that's not obviously possible to fix without frame-local face remapping (which was, apparently, an Xemacs feature), and it's not really a big deal anyway.

gonewest818 commented 6 years ago

Agreed, it's not a big deal for me either. Recently I added a "caveats" section to the readme because the first user-reported issue (#3) is most likely this same quirk.