gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

A recent change in Emacs 28 has made the third argument (WHEN) of define-obsolete-function-alias mandatory. #50

Closed jeffkowalski closed 3 years ago

jeffkowalski commented 3 years ago

Please add when argument to these calls:

https://github.com/gonewest818/dimmer.el/blob/c5c881cc5c0401467fda2864590558fc612c2943/dimmer.el#L130 https://github.com/gonewest818/dimmer.el/blob/c5c881cc5c0401467fda2864590558fc612c2943/dimmer.el#L601

gonewest818 commented 3 years ago

Ok, and thanks for reporting this.

On Jan 9, 2021, at 10:11 AM, Jeff Kowalski notifications@github.com wrote:

 Please add when argument to these calls:

https://github.com/gonewest818/dimmer.el/blob/c5c881cc5c0401467fda2864590558fc612c2943/dimmer.el#L130 https://github.com/gonewest818/dimmer.el/blob/c5c881cc5c0401467fda2864590558fc612c2943/dimmer.el#L601

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

gonewest818 commented 3 years ago

I don't have Emacs 28 compiled at the moment but I am running some basic checks on 25, 26, 27 and 28 in CircleCI. Pls let me know if this doesn't resolve it for you.