gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

Wrong number of arguments #52

Closed azzamsa closed 3 years ago

azzamsa commented 3 years ago

After updating dimmer.el today. I got this error:

error in minibuffer:

Eager macro-expansion failure: (wrong-number-of-arguments (3 . 4) 2) [2 times]
define-obsolete-variable-alias: Wrong number of arguments: (3 . 4), 2

error in emacs --debug-init:

Debugger entered--Lisp error: (wrong-number-of-arguments (3 . 4) 2)
  #f(compiled-function (obsolete-name current-name when &optional docstring) "Set OBSOLETE-NAME's function definition to CURRENT-NAME and mark it obsolete.\n\n(define-obsolete-function-alias \\='old-fun \\='new-fun \"22.1\" \"old-fun's doc.\")\n\nis equivalent to the following two lines of code:\n\n(defalias \\='old-fun \\='new-fun \"old-fun's doc.\")\n(make-obsolete \\='old-fun \\='new-fun \"22.1\")\n\nWHEN should be a string indicating when the function was first\nmade obsolete, for example a date or a release number.\n\nSee the docstrings of `defalias' and `make-obsolete' for more details." #<bytecode -0xd0475dba45093cc>)('dimmer-activate 'dimmer-mode)
  (define-obsolete-function-alias 'dimmer-activate 'dimmer-mode)
  straight--activate-package-autoloads((:type git :flavor melpa :host github :repo "gonewest818/dimmer.el" :package "dimmer" :local-repo "dimmer.el"))
  #f(compiled-function () #<bytecode -0xcb8b096188af8e7>)()
  straight--transaction-exec(use-package-\(:type\ git\ :flavor\ melpa\ :host\ github\ :repo\ \"gonewest818/dimmer\.el\"\ :package\ \"dimmer\"\ :local-repo\ \"dimmer\.el\"\)-nil-nil :now #f(compiled-function () #<bytecode -0xcb8b096188af8e7>))
  straight-use-package(dimmer)
  load-with-code-conversion("/home/user/.emacs.d/core/aza-ui.el" "/home/user/.emacs.d/core/aza-ui.el" nil t)
  require(aza-ui)
  load-with-code-conversion("/home/user/.emacs.d/init.el" "/home/user/.emacs.d/init.el" t t)
  load("/home/user/.emacs.d/init" noerror nomessage)
  startup--load-user-init-file(#f(compiled-function () #<bytecode -0x13fc8c3bc82ff556>) #f(compiled-function () #<bytecode 0xc0853d4c321e18c>) t)
  command-line()
  normal-top-level()

config:

(use-package dimmer  
  :defer 0.2
  :config
  (setq dimmer-exclusion-predicates '(helm--alive-p window-minibuffer-p))
  (setq dimmer-exclusion-regexp-list
        '("^\\*[h|H]elm.*\\*" "^\\*Minibuf-[0-9]+\\*"
          "^.\\*which-key\\*$" "^*Messages*" "*LV*"
          "transient" " *company-box-"))
  (setq dimmer-fraction 0.50)
  (dimmer-mode t))

version:

4abe515 (HEAD -> master, upstream/master, origin/master) 9 months ago fix for dimmer-configure-company-box causing runtime errors (Neil Okamoto)

GNU Emacs 28.0.50 (build 7, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2021-01-25
gonewest818 commented 3 years ago

Hi. Well, that commit hash you listed 4abe515 is quite a few months old, and the fix you need for Emacs 28 went in just about 2 weeks ago... can you adjust your configuration and see if you can get a more recent version installed? That should be the fix you need.

azzamsa commented 3 years ago

Oh my bad.

I always use straight.el to pull the newest version.

-(use-package dimmer
-  :straight (dimmer :type git :flavor melpa :host github :repo "gonewest818/dimmer.el" :remote "upstream"
-                    :fork (:host github :repo "azzamsa/dimmer.el" :remote "origin" :branch "master"))

I removed that lines, because the upstream now fixes everything. Unfortunately, I typed the wrong command.

 git pull origin master --rebase

and it should be

 git pull upstream master --rebase

Sorry for the noise. Thanks a lot for dimmer.el!

gonewest818 commented 3 years ago

No problem! Glad it’s working for you.