search

gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

Dimming windows instead of buffers #58

Closed Patryk27 closed 2 years ago

Patryk27 commented 2 years ago

Hi 🙂

It seems like dimmer.el internally relies on buffer name, which means that e.g. splitting a buffer into separate windows causes all of those windows to remain highlighted (since all are backed by the same buffer), instead of highlighting only one of them (the one where the caret is / the one with active modeline):

image

Could this behavior be somehow configurable?

Thanks for this package, Cheers.

gonewest818 commented 2 years ago

Hi Patryk. Indeed I would prefer if dimmer could do this, but Emacs doesn't have the ability to set window-specific face remaps. I'm limited to setting the "dimmed" face at the the buffer level. Thanks-

Patryk27 commented 2 years ago

Aw, yeah, if that's a fundamental thing, then we're out of luck; well, thanks for responding! 🙂

strobe commented 7 months ago

Hi Patryk. Indeed I would prefer if dimmer could do this, but Emacs doesn't have the ability to set window-specific face remaps. I'm limited to setting the "dimmed" face at the the buffer level. Thanks-

It looks like is not true anymore.

I noticed that another dimming package doing that https://github.com/mina86/auto-dim-other-buffers.el and its doc mention that is available since version 27.

Emacs doc has some info about that https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Remapping.html

Seems it's required to use :filtered in order to apply remapping to specific window.

here is how it used in auto-dim-other-buffers: https://github.com/mina86/auto-dim-other-buffers.el/blob/master/auto-dim-other-buffers.el#L143

@gonewest818 please check.