search

gonewest818 / dimmer.el

Interactively highlight which buffer is active by dimming the others.
GNU General Public License v3.0
267 stars 14 forks source link

selectrum compatibility #60

Open bcclaywell opened 2 years ago

bcclaywell commented 2 years ago

I'm having trouble with the active window being dimmed when the selectrum minibuffer opens, despite window-minibuffer-p being in dimmer-prevent-dimming-predicates. I've tried various things. There's a buffer-local variable called selectrum-is-active that I tried writing a simple predicate for:

(defun selectrum-is-active-p ()
  (and selectrum-is-active t))

That doesn't seem to do the trick, the active window still gets dimmed when the focus moves to the selectrum minibuffer. Not sure what else to try, but it would be great if selectrum and dimmer could work together!

gonewest818 commented 2 years ago

Hmm, not sure, I’ll have to install selectrum to test this. Thanks for the report!

On Dec 23, 2021, at 1:21 PM, Brian Claywell @.***> wrote:

 I'm having trouble with the active window being dimmed when the selectrum minibuffer opens, despite window-minibuffer-p being in dimmer-prevent-dimming-predicates. I've tried various things. There's a buffer-local variable called selectrum-is-active that I tried writing a simple predicate for:

(defun selectrum-is-active-p () (and selectrum-is-active t)) That doesn't seem to do the trick, the active window still gets dimmed when the focus moves to the selectrum minibuffer. Not sure what else to try, but it would be great if selectrum and dimmer could work together!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

Stebalien commented 2 years ago

I'm seeing the same thing with vertico. dimmer-process-all is getting called with force by dimmer-config-change-handler (at least for me).

xendk commented 3 months ago

Ended up here because of vertico too.

dimmer-process-all is getting called with force by dimmer-config-change-handler

Ah, yes, selectrum and vertico causes window resizing, which triggers window-configuration-change-hook, which dimmer hooks into.

The problem gets even worse with consult that'll preview the buffer in consult-buffer.

gonewest818 commented 3 months ago

I’ve been swamped in day-job work but sounds like I need to take another run at dimmer bugs and compatibility.  Thanks for your patience!On May 5, 2024, at 2:43 PM, Thomas Fini Hansen @.***> wrote: Ended up here because of vertico too.

dimmer-process-all is getting called with force by dimmer-config-change-handler

Ah, yes, selectrum and vertico causes window resizing, which triggers window-configuration-change-hook, which dimmer hooks into. The problem gets even worse with consult that'll preview the buffer in consult-buffer.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

xendk commented 3 months ago

I think it could be fixable for selectrum and vertico, but either with consult is a tough nut. Basically, dimmer would have to hook into consult previewing and "keep up" with it while one browse the selection. I'm not sure if it would be worth the effort.

It kinda makes sense that the originating buffer gets dimmed when selectrum/vertico is active, and I, personally, of course, don't mind it. So I would probably prefer if the current behaviour was still an option, as a halfway solution that doesn't dim the originating buffer, but doesn't keep up when consult previews buffers/files would be more jarring.