Open Davidbrcz opened 6 months ago
I have same probelm when I activate dimmer-mode
as follows:
Debugger entered--Lisp error: (wrong-type-argument stringp reset)
color-defined-p(reset)
dimmer-face-color(forge-topic-header-line 0.5)
dimmer-dim-buffer(#<buffer *which-key*> 0.5)
dimmer-process-all(t)
dimmer-config-change-handler()
redisplay_internal\ \(C\ function\)()
I have a simple workaround for it.
I fixed it in dimmer-face-color
by changing the definitions of fg/bg as follow
(defun dimmer-face-color (f frac)
"Compute a dimmed version of the foreground color of face F.
If `dimmer-adjust-background-color` is true, adjust the
background color as well. FRAC is the amount of dimming where
0.0 is no change and 1.0 is maximum change. Returns a plist
containing the new foreground (and if needed, new background)
suitable for use with `face-remap-add-relative`."
(let* (
(fg-original (face-foreground f))
(fg (if (eq 'reset fg-original) 'unspecified fg-original))
(bg-original (face-background f))
(bg (if (eq 'reset bg-original) 'unspecified bg-original))
Hello
Original issue
I using dimmer to dim the inactive buffers, Everything has been working fine for years. Recently, I started to get errors, for instance, when pressing Enter to see a commit content in the recent commit lists and the buffers are not dimmed any more.
The commit that introduced the code that seems related to the issue is In forge-topic-mode use forge--format-topic-line for header-line
A full backtrace.