search

gongminmin / KlayGE

KlayGE is a cross-platform open source game engine with plugin-based architecture.
http://www.klayge.org
GNU General Public License v2.0
2.06k stars 352 forks source link

Fix some issues found by PVS-Studio #1 #230

Closed dimhotepus closed 11 months ago

dimhotepus commented 1 year ago

Product page: https://www.viva64.com/en/pvs-studio/ How to use for free: https://www.viva64.com/en/b/0600/

gongminmin commented 1 year ago

First, if the PR is a commercial of PVS-Studio, it's not welcomed. Second, some of the changes are cool, but some are not necessary. I can't separate them if they are all in one PR.

dimhotepus commented 1 year ago

First, if the PR is a commercial of PVS-Studio, it's not welcomed. Second, some of the changes are cool, but some are not necessary. I can't separate them if they are all in one PR.

PR is not commercial, just a demonstration of product possibilities. PVS-Studio is free for OSS.

The free license cannot be applied to the following types of projects:

  1. commercial (the author profits from the project directly or indirectly);
  2. owned by organizations (the project has a corporate profile on GitHub and/or other ownership types);
  3. developed by organizations (financing and/or hiring developers);
  4. mirrors and forks (for example, copies of projects that do not meet these conditions).

The PVS-Studio license for Open Source is intended for personal creative projects. This license allows the author to accept donations from their community.

Regarding second issue, could you please mentions which commits are not required and I'll drop them?

gongminmin commented 1 year ago

I've made a round of code review. Basically, no need to change the member initialization, BSTR, or overflow. They are not problems.

WonderCooper commented 11 months ago

您好，已收到您的邮件，我会尽快处理，谢谢