search

gongo / turnip_formatter

A pretty formatter for Turnip
http://gongo.hatenablog.com/entry/2013/04/18/203426
MIT License
34 stars 24 forks source link

Support activesupport v7 #104

Closed masayuki0812 closed 1 year ago

masayuki0812 commented 1 year ago

activesupport 7 has String#{demodulize,underscore} as same as 6. Ref: https://github.com/gongo/turnip_formatter/pull/102

Travis is not running now, but I confirmed test passed on local. So, it seems ok.

$ bundle exec rake test
/Users/me/.rbenv/versions/3.2.2/bin/ruby -I"lib:test" /Users/me/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb "test/turnip_formatter/renderer/html/test_data_table.rb" "test/turnip_formatter/renderer/html/test_doc_string.rb" "test/turnip_formatter/renderer/html/test_index.rb" "test/turnip_formatter/renderer/html/test_runtime_error.rb" "test/turnip_formatter/renderer/html/test_statistics_feature.rb" "test/turnip_formatter/renderer/html/test_statistics_speed.rb" "test/turnip_formatter/renderer/html/test_statistics_tag.rb" "test/turnip_formatter/renderer/html/test_step.rb" "test/turnip_formatter/renderer/test_html.rb" "test/turnip_formatter/resource/scenario/test_failure.rb" "test/turnip_formatter/resource/scenario/test_pass.rb" "test/turnip_formatter/resource/scenario/test_pending.rb" "test/turnip_formatter/step_template/test_base.rb" "test/turnip_formatter/step_template/test_exception.rb" "test/turnip_formatter/step_template/test_source.rb" 
Loaded suite /Users/me/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
Finished in 0.127823 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
51 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
398.99 tests/s, 547.63 assertions/s
gongo commented 1 year ago

@masayuki0812 Sorry for the late reply. Good PR, thanks!

gongo commented 1 year ago

This changes has been released in v0.8.0