gongo / turnip_formatter

A pretty formatter for Turnip
http://gongo.hatenablog.com/entry/2013/04/18/203426
MIT License
34 stars 24 forks source link

Add "puts FAILED" for Jenkins, else it doesn't recognize FAILED steps #58

Closed JohnBat26 closed 9 years ago

gongo commented 9 years ago

Yeah :smile: Thanks for pull-request :+1: But I cannot understand necessity of this patch for me right now :muscle: See you next time :wave:

JohnBat26 commented 9 years ago

@gongo Add "puts FAILED" for Jenkins, else it doesn't recognize FAILED steps

gongo commented 9 years ago

You should be able to recognize the failed steps using a status code of RSpec

JohnBat26 commented 9 years ago

@gongo hmm. If I start test as:

 bundle exec rspec  -r turnip/rspec spec/acceptance/ -r turnip_formatter --format RSpecTurnipFormatter --out report.html

then I don't get any info info in console. And Jenkins does false positive decision about build.

I one of my steps failed, Jenkins didn't know about it at all :(

gongo commented 9 years ago

Try add to the end:

- bundle exec rspec  -r turnip/rspec spec/acceptance/ -r turnip_formatter --format RSpecTurnipFormatter --out report.html
+ bundle exec rspec  -r turnip/rspec spec/acceptance/ -r turnip_formatter --format RSpecTurnipFormatter --out report.html --format documentation
JohnBat26 commented 9 years ago

Ok. Thanks :+1: