Doors platforms triggers

[victorbstan]

Why?

Doors, platforms and triggers needed some updates to bring their feature set closer to parity with Quake game features

What?

• Doors auto-close after being triggered (TODO: don't close if something is blocking the door)
• Doors & Platforms auto generate trigger volumes if they are not targets or require keys
• Platforms auto generate triggers if they are targets, after they have been triggered once
• TODO: platforms need to return to their initial position unless wait -1 or toggle on. (currently, they are, but the target position is closed, when it should be open, so they return to the wrong position)

[victorbstan]

Note, platforms should probably not inherit from doors

[victorbstan]

This has a lot of changes and the more I review it, the more I think I want to refactor it...

[gongpha]

I confirmed this PR fixes a lot of movable brushes (e.g. e1m1, e1m8) and makes doors open properly from the map logic.

Some problematic brushes (most of them are platform brushes, e.g. e4m2, that one platform brush under the water pool) are still broken, though. (According to #15)

[victorbstan]

• Platforms should now be placed correctly and extend and retract after being triggered (still some things to work on)
• Separated doors, secret, plats, buttons, from sharing code (not inheriting from doors) in order to prevent bugs and simplify development for each
• Secret doors should now open and close properly in any direction
• Added consts for spawnflags to funcs, and triggers, and mechanism to use spanwflag const name instead of hex or binary (more readable code)

[victorbstan]

• Sounds for doors, secrets, plats, buttons, should respect worldtype and sounds settings correctly
• cleaned up properties fetching across the func scripts
• doors with keys have proper worldtype missing key sound
• added most if not all default properties as constants in funcs

As far as I know this is mostly feature complete for plats, doors, secret doors and buttons.

TODO (in the future :))

• apply damage to player if blocking
• trigger when shot/damaged for some buttons/doors/secrets that take damage
• extend play of looping sound according to animation duration

[gongpha]

Are these doors supposed to be closed after leave them ?

https://github.com/gongpha/gdQmapbsp/assets/13400398/726e3ef8-8019-4728-a591-464568e46e7c

[victorbstan]

Are these doors supposed to be closed after leave them ? Godot_v4.0.3-stable_win64.2023-07-16.01-54-51-425.mp4

What map is this? (Found it, start map)

[victorbstan]

Are these doors supposed to be closed after leave them ? Godot_v4.0.3-stable_win64.2023-07-16.01-54-51-425.mp4

Last commit should fix this, and a couple of other door related bugs

[victorbstan]

Found a bug that exists in master as well regarding non axially aligned buttons (fixed by latest commit) - see E3M4 for example button

fixed by 694bd2c

[victorbstan]

https://github.com/gongpha/gdQmapbsp/assets/315297/8a9a56e1-2372-410e-ae75-c612a488c0f7

fixed button add calc

[victorbstan]

Latest updates:

• various bug fixes, regression fixes
• trigger counter now shows message and triggers next target (see E1M4)
• trigger once implements NO TOUCH flag

[gongpha]

trigger_onlyregistered shows a message for unregistered users while I'm in registered mode.

[victorbstan]

Fixed registered message regression problem, caused by wanting to show trigger once messages

[gongpha]

I saw you fixed some func_train issues. Notice 2 magic gate cubes in E1M2 are now moving synchronously to the timer. I hope you can fix these remaining issues :

---

The moving speed is slightly slow. Notice the platform moves through the wood platforms :

https://github.com/gongpha/gdQmapbsp/assets/13400398/6732e255-fbc2-4183-a5b5-aa05de1fbd38

They're ping-pong looped on some func_train that has no looping :

https://github.com/gongpha/gdQmapbsp/assets/13400398/76923a6e-b09c-42e8-bad0-1fa4e48d583b

[victorbstan]

I'll take a look at fixing those. There's probably other bugs, and I plan on fixing and implementing all missing entity features, at least to a state where it's playable, if not absolutely the same. But it might not all be in this one PR, since this one is getting quite large and out of hand lol!

[victorbstan]

Platforms now should move to correct time/duration and wait according to wait settings for each path corner.

[gongpha]

Strangely sounds playback when touching doors.

https://github.com/gongpha/gdQmapbsp/assets/13400398/186d1698-0346-429b-9674-503922c9c1cd