Project Feedback!

[codepathreview]

:+1: Good job. A few notes after checking out the code:

• Consider adding more UI polish
• Good to see you were able to format the timestamp cleanly (consider using short format 2h)
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
• Good job on getting the new tweet displayed on timeline
• Nice touch with the character count being displayed while the user composes a tweet
• Glad to see you made the compose activity into a dialog instead
• Correctly used RecyclerView instead of ListView
• Good job moving compose to FloatingActionButton (consider following material design guidelines on padding)
• Good to see you added DBFlow annotations to the models
• Consider adding progress bars to your app whenever a network request goes out

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[codepathreview]

:+1: Nice work. A few notes after checking out the code:

• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nice to see you used the ViewPager to properly setup the tabs
• Nice job with including progress support
• Could you pls point me to code where this is implemented - Implements robust error handling, check if internet is available, handle error cases, network failures ? I was not able to find
• Sorry you wont be getting credit for this - The user that wrote the original tweet is automatically "@" replied in compose. "@"username should be appended to tweet

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.
/cc @codepathreview

[gongxinheng]

Hi, thanks for the review and feedback! Here are my answers to your question: Could you pls point me to code where this is implemented - Implements robust error handling, check if internet is available, handle error cases, network failures ? I was not able to find I have a config class https://github.com/gongxinheng/codepath-twitter-client/blob/master/app/src/main/java/com/codepath/apps/restclienttemplate/utils/Config.java to check and set if is online.

Sorry you wont be getting credit for this - The user that wrote the original tweet is automatically "@" replied in compose. "@"username should be appended to tweet I put "@"username right below the reply TextView since I found if I put it direct inside the TextView, it will be treated as a part of the reply text. /cc @codepathreview