gonicus / gofaxip

GOfax.IP - T.38 / Fax Over IP backend for HylaFAX using FreeSWITCH
GNU General Public License v2.0
123 stars 43 forks source link

CircleCI on pull requests #60

Open EtienneBruines opened 3 years ago

EtienneBruines commented 3 years ago

You might want to configure CircleCI tests to run on pull requests, and mark them as requirements for merging.

Mostly this one: https://circleci.com/docs/2.0/enable-checks/

Background info:

https://docs.github.com/en/github/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-status-checks-before-merging

That way, you know whether tests run before merging :smile: