goniszewski / grimoire

Bookmark manager for the wizards 🧙
https://grimoire.pro
MIT License
2.12k stars 65 forks source link

Fix PocketBaseUrl in Config.ts #112

Closed RC1140 closed 3 months ago

RC1140 commented 4 months ago

This PR fixes an issue where the POCKETBASE_URL is evaluated incorrectly due to the ternary added for dev config. Currently it will evaluate the POCKETBASE_URL to either localhost or pocketbase and never to the actual value provided by env.PUBLIC_POCKETBASE_URL || getProcessEnvValue('PUBLIC_POCKETBASE_URL')

RC1140 commented 3 months ago

@goniszewski Any chance you could review this and merge (unless you have fixed the issue in another PR)