Fix crash and update for Swift 4

gontovnik / DGRunkeeperSwitch

Runkeeper design switch control

MIT License

1.88k stars 175 forks source link

Fix crash and update for Swift 4 #48

Closed alexanderkhitev closed 2 years ago

phoney commented 7 years ago

This looks like a good way to fix the problems on iOS 11.

fbonilla commented 6 years ago

How come this PR has never been merged?

AndriyGo commented 6 years ago

@alexanderkhitev maybe we should move this to some separate fork? Looks like this repo is not updated...

phoney commented 6 years ago

I use pod 'DGRunkeeperSwitch', :git => 'https://github.com/alexanderkhitev/DGRunkeeperSwitch.git', :branch => 'master'

fbonilla commented 6 years ago

I've decided to use another project with more activity. https://github.com/gmarm/BetterSegmentedControl

alexanderkhitev commented 6 years ago

@AndriyGo sorry for late response I was on holiday. I do not mind if someone does that, an active fork from my fork, because I currently do not have time to support the open source framework and accept or view pull requests.

phoney commented 6 years ago

@AndriyGo Your commits break this branch for me. The first part of this PR updated to swift 4 and fixed some compile errors in the 1.1.4 version. You've updated to swift 4.2 without any kind of versioning or tag. My project hasn't updated to swift 4.2 so I can't consume your commits. The only way I can still use this branch is specifying the commit. That's not how this is supposed to work.

pod 'DGRunkeeperSwitch', :git => 'https://github.com/alexanderkhitev/DGRunkeeperSwitch.git', :commit => '2916ed50f8c57efc5f9b31867f41f9a670abe76a'