search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Updated comments for all the functions and added a doc comment to the pa... #107

Closed btracey closed 9 years ago

btracey commented 9 years ago

...ckage

kortschak commented 9 years ago

General comment - always run a local godoc -http=:6060 and look at the rendering.

Where you use "mxn", maybe consider "m⨉n" or "m by n". Similarly for "n x n". Harmonise spacing and use of "by", "x" or "⨉".

For Drotm, s/2 x N/2 x n/ with above consideration.

btracey commented 9 years ago

Okay, I think I got all of the n⨉n rectified.

btracey commented 9 years ago

I also subbed ∗ for * in non-indented blocks for elements that are not accessed. It looks much better in godoc.

btracey commented 9 years ago

PTAL

btracey commented 9 years ago

Fixed Drotg comment. PTAL.

kortschak commented 9 years ago

s/on/regarding/ - this may be another language variant conflict.

s/. This agrees with/ and/

btracey commented 9 years ago

Done.

On Feb 5, 2015, at 1:42 PM, Dan Kortschak notifications@github.com wrote:

s/on/regarding/ - this may be another language variant conflict.

s/. This agrees with/ and/ — Reply to this email directly or view it on GitHub https://github.com/gonum/blas/pull/107#issuecomment-73134781.

kortschak commented 9 years ago

It looks like '⨉' is not available on all machines (e.g. not on my workstation). Either try '⨯' (named "Vector or Cross Product"), '×' (named "Multiplication sign" - low unicode point, so probably more available), or revert to 'x'. Sorry.

Otherwise LGTM, thank you.