search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Code-generated single precision native BLAS #111

Closed kortschak closed 9 years ago

kortschak commented 9 years ago

PTAL @btracey @fhs

This depends on gonum/internal#5.

btracey commented 9 years ago

Is it possible to translate the tests as well?

kortschak commented 9 years ago

Not today, but we can look at that in the future. File an issue for that.

fhs commented 9 years ago

Please reference issue #105 in commit message, optionally closing it in the process.

kortschak commented 9 years ago

PTAL

kortschak commented 9 years ago

Tests for the math32 code added - identifying that the float64 sqrt code does not translate.

fhs commented 9 years ago

At some stage math32 may want to move into gonum/internal, but we can think about that if other pakages start to use float32 routines.

I think it's worth creating a math32 package right now. It doesn't need to be in gonum/internal. It could be in the current repository. It'll greatly simplify the translation since you can just import "math32" as "math": 

sed -e 's!"math"!math "github.com/gonum/blas/internal/math32"!'

BTW, sqrt_amd.go should be sqrt_amd64.go. Similarly for sqrt_amd.s.

kortschak commented 9 years ago

PTAL

fhs commented 9 years ago

I'd also rename the file math32.go to math.go and math32_test.go to math_test.go, but I'll leave it to your liking.

kortschak commented 9 years ago

All addressed, PTAL.

fhs commented 9 years ago

LGTM. Thanks!

kortschak commented 9 years ago

Thank you for the comments.