search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

testblas: test Level 1 single precision #116

Closed fhs closed 5 years ago

fhs commented 9 years ago

I initially started by adding the test functions in testblas package, but that turned out to be too tedious. You have to rename a LOT of local identifiers (TestX, XCase, XCases, functions in common.go, etc.). I really think testblas should be split up into sub-packages for each type (testblas/single, testblas/double, etc.). It'd also help to split up blas/native into sub-packages. It's more idiomatic to have small simple packages instead of monolithic packages. It leads to smaller binaries. There are some guidelines in the recent Go package naming blog post (in particular see "Break up generic packages" section).

This PR probably shouldn't be merged until the packages are split up.

kortschak commented 9 years ago

I think splitting is certainly worth considering.

fhs commented 9 years ago

For now, I propose renaming testblas package to testblas/blas64 (package naming subject to debate) and rename the function and interface names: DdotTest -> DotTest, Ddotter -> Dotter, etc.

Splitting up blas/native can be done later (if ever) but it'll definitely help with auto-generating code.

vladimir-ch commented 5 years ago

Closing because this repository is no longer maintained. Development has moved to https://github.com/gonum/gonum.