search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Remove blas support for column major matrices #13

Closed btracey closed 10 years ago

btracey commented 10 years ago

It was decided, after discussion on the gonum-dev list, to remove support for column-major matrices in the blas package. This commit completely removes all public support for the blas interface. Some necessary residuals remain in the cblas package because the c functions require specifying an order. However, these residuals are private and are thus invisible to package users.

Several of the testing scripts tested column major implementation only. This commit comments out those tests for the time being until they can be migrated to row major.

dane-unltd commented 10 years ago

I can fix the tests once this is merged. Should not be too complicated.

btracey commented 10 years ago

That would be great. I figured that would be the case which is why I commented them out. Do you give this an LGTM?

dane-unltd commented 10 years ago

Yes LGTM, as a side note, I think it is more convenient to submit pull requests from a branch in the main repo.